[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rC355593: [ASTImporter] Handle redecl chain of FunctionTemplateDecls (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D58494?vs=189665=189694#toc Repository: rC

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4967 +template static auto getTemplateDefinition(T *D) -> T * { + auto *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); if (!ToTemplatedDef) shafik wrote: > shafik wrote: > > Can we

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 189665. martong marked 6 inline comments as done. martong added a comment. - Add asserts Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494 Files: lib/AST/ASTImporter.cpp

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

shafik accepted this revision. shafik added a comment. LGTM outside of the question I had. Comment at: lib/AST/ASTImporter.cpp:4967 +template static auto getTemplateDefinition(T *D) -> T * { + auto *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); if

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added a comment. @shafik, Could you please take a look? I have run the LLDB tests on our macOS and I could not discover any regression. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thanks for the fixes! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://reviews.llvm.org/D58494

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4966 // it has any definition in the redecl chain. -static ClassTemplateDecl *getDefinition(ClassTemplateDecl *D) { - CXXRecordDecl *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); +template static

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 188379. martong marked 4 inline comments as done. martong added a comment. - getDefinition -> getTemplateDefinition - Remove comments for braces, added FIXME Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

a_sidorin added a comment. Hi Gabor, The patch looks OK overall but I have some comments inline. Comment at: lib/AST/ASTImporter.cpp:4966 // it has any definition in the redecl chain. -static ClassTemplateDecl *getDefinition(ClassTemplateDecl *D) { - CXXRecordDecl

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of function templates are not handled well currently. We want