[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith abandoned this revision. dexonsmith added a comment. I just pushed 31e14f41a21f9016050a20f07d5da03db2e8c13e , which moves KnownModules into ModuleMap as an alternative. In D58497#1648134

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a comment. I don't think you need prior frontend expertise, just some time and patience since the modules code has some technical debt. If you are still willing to look at it, I agree with Richard's suggestion that we could merge this with the map in the Module Manager. One a

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. I have not seen this problem resurface to be honest. When we initially hit it, changing the path for the build worked around the problem for us so we weren't really hitting in any longer. I posted this because I realized the possibility exists of having these dangling

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

rsmith added a comment. Do we need `KnownModules` at all? It seems to serve a very similar purpose to the `Modules` string map on `ModuleMap`. (The main difference seems to be that `KnownModules` can cache module load failures.) If we can keep only a single data structure tracking this, owned b

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a comment. Herald added a subscriber: wuzish. Is this still a problem? I'd be interested to understand *why* the preprocessor is going away here. Is the `CompilerInstance` being reused for two different compilations? Is that what we should fix instead? Repository: rC Clan

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a reviewer: bruno. dexonsmith added a comment. +bruno Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Herald added a subscriber: jsji. Ping. Does anyone think this is a good idea? Bad idea? Have any further comments? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 _

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. In D58497#1449306 , @dblaikie wrote: > In D58497#1449243 , @nemanjai wrote: > > > Ping. > > > Unfortunately Richard Smith is out for a few weeks at the moment, so might > take a little bit

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dblaikie added a comment. In D58497#1449243 , @nemanjai wrote: > Ping. Unfortunately Richard Smith is out for a few weeks at the moment, so might take a little bit before he can get to this. It's odd to me that this lacks a test case - but you mention

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Ping. If there are no objections in the next week or so, I'll commit this and it can be reviewed post-commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 _

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58497/new/ https://reviews.llvm.org/D58497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai created this revision. nemanjai added a reviewer: rsmith. Herald added a subscriber: jdoerfert. Herald added a project: clang. When the `Preprocessor (PP)` in compiler instance is going away, we should clear the cache of any pointers that it owns as they will be destroyed. This is one p