[PATCH] D58531: [clang] Specify type of pthread_create builtin

probinson added a reviewer: jdoerfert. probinson added a comment. We've started running into this too in building the PS4 system. +jdoerfert who added pthread_create to the builtin list. Looking at the patch, it seems straightforward enough although clearly needs clang-format-diff run over it.

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jdoerfert added a comment. In D58531#1599209 , @probinson wrote: > We've started running into this too in building the PS4 system. +jdoerfert > who added pthread_create to the builtin list. > > Looking at the patch, it seems straightforward enough althoug

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 added a comment. In D58531#1611356 , @jdoerfert wrote: > In D58531#1599209 , @probinson wrote: > > > We've started running into this too in building the PS4 system. +jdoerfert > > who added pthread_create to

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I like the patch and I think it is fine. Small nits: Could we have a test for " we can detect dodgy pthread_create declarations" and maybe `pthread[_attr]_t`? There is an unresolved com

[PATCH] D58531: [clang] Specify type of pthread_create builtin

srhines added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9574 - assert(!RequiresICE && "Result of intrinsic cannot be required to be an ICE"); + assert(!RequiresICE && "Result of function cannot be required to be an ICE"); I would just remov

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 updated this revision to Diff 223871. jrtc27 added a comment. Rebased, added explicit no-warning test, clang-format'ed, updated assertion message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531 Fil

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 marked an inline comment as done. jrtc27 added a comment. In D58531#1662466 , @jdoerfert wrote: > I like the patch and I think it is fine. > > Small nits: > Could we have a test for " we can detect dodgy pthread_create declarations" > and maybe `

[PATCH] D58531: [clang] Specify type of pthread_create builtin

rsmith added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1223 /// The number of special type IDs. const unsigned NumSpecialTypeIDs = 8; This presumably needs to be increased. Are we missing test coverage that would ha

[PATCH] D58531: [clang] Specify type of pthread_create builtin

MaskRay added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2058 +/// Missing a type from +GE_Missing_pthread }; You can append a comma so that next time the list gets appended the diff does not have to touch this line. Reposito

[PATCH] D58531: [clang] Specify type of pthread_create builtin

MaskRay added a comment. Ping @jrtc27 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 created this revision. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. Currently, pthread_create's type string is empty, so GetBuiltinType fails and any header declaring it gives a -Wbuiltin-requires-header warning, which gives a false-positive when including pthr

[PATCH] D58531: [clang] Specify type of pthread_create builtin

jrtc27 added a comment. A separate point is whether it makes sense to be emitting this warning in the first place for `GE_Missing_type`. I'd argue that, if we don't know the type of the builtin, we should never emit the warning, since otherwise we always emit the warning even for legitimate ins