rnk added a comment.
Sounds good, thanks for debugging this.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58663/new/
https://reviews.llvm.org/D58663
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL354916: [ASTImporter] Add support for importing ChooseExpr
AST nodes. (authored by tmroeder, committed by ).
Herald added
tmroeder added a comment.
I'm going to submit this patch again, since that I believe I understand the
problem, and I have tested this version on Win10 with the latest MSVC (other
than the expectation that I just added, but that test wasn't a problem on the
Windows builders, and the new
tmroeder updated this revision to Diff 188397.
tmroeder added a comment.
Added the other expectation, as suggested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58663/new/
https://reviews.llvm.org/D58663
Files:
martong added inline comments.
Comment at: clang/unittests/AST/ASTImporterTest.cpp:1344
+
+ EXPECT_EQ(FromChooseExpr->isConditionTrue(),
ToChooseExpr->isConditionTrue());
+}
To compensate the skipping of the template test, perhaps we should have
another
tmroeder updated this revision to Diff 188307.
tmroeder added a comment.
Dropped the C++ part of the ImportChooseExpr test entirely.
This is the part that was breaking the tests on Windows, and after further
experimentation, it turns out that clang on Windows never expands the template
under
tmroeder created this revision.
tmroeder added reviewers: shafik, a_sidorin, martong, aaron.ballman, rnk.
tmroeder added a project: clang.
Herald added a reviewer: a.sidorin.
This allows ASTs to be merged when they contain ChooseExpr (the GNU
__builtin_choose_expr construction). This is needed,
