This revision was automatically updated to reflect the committed changes.
Closed by commit rC355592: [analyzer] Handle comparison between non-default AS
symbol and constant (authored by dstenb, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58665/new
dstenb added a comment.
Thanks for the review! I'll submit this shortly then.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58665/new/
https://reviews.llvm.org/D58665
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks again! Please commit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58665/new/
https://reviews.llvm.org/D58665
___
cfe-commits mailing
dstenb updated this revision to Diff 188538.
dstenb added a comment.
Address comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58665/new/
https://reviews.llvm.org/D58665
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/ptr-cmp-const-trunc.cl
Index: test/An
NoQ added a comment.
Hi, thanks!, i think this is correct. As in, `LocAsInteger` was clearly a
mistake to begin with, but this change shouldn't make it worse.
You should be able to get away with not supporting comparisons between regions
without symbolic base [as integers] and concrete integers
dstenb created this revision.
dstenb added reviewers: NoQ, zaks.anna, george.karpenkov.
Herald added subscribers: cfe-commits, Charusso, jdoerfert, dkrupp, donat.nagy,
Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: clang.
When comparing a sym
