This revision was automatically updated to reflect the committed changes.
Closed by commit rC357394: [ASTImporter] Make ODR error handling configurable
(authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D58897?vs=192070&id=193086#toc
Repository:
rC Clang
gamesh411 added a comment.
ping @a_sidorin
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58897/new/
https://reviews.llvm.org/D58897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
gamesh411 updated this revision to Diff 192070.
gamesh411 marked an inline comment as done.
gamesh411 added a comment.
- Revert member order to original
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58897/new/
https://reviews.llvm.org/D58897
Files:
include/cla
gamesh411 added inline comments.
Comment at: include/clang/AST/ASTStructuralEquivalence.h:81
EqKind(EqKind), StrictTypeSpelling(StrictTypeSpelling),
-ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch), Complain(Complain) {}
+Complain(Complain), ErrorOnTagType
a_sidorin added a comment.
Hi Gabor,
This patch LGTM mostly, but there is a comment inline.
Comment at: include/clang/AST/ASTStructuralEquivalence.h:81
EqKind(EqKind), StrictTypeSpelling(StrictTypeSpelling),
-ErrorOnTagTypeMismatch(ErrorOnTagTypeMismatch), Comp
martong added a comment.
Ping
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58897/new/
https://reviews.llvm.org/D58897
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
