[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL359603: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thank you for unifying `crtbegin{,S,T}.o` 😊 I hope Android people can make their `crtbegin*.o` files simpler, one day.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ htt

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek added a comment. @MaskRay can you review this again now that there's just a single `crtbegin.o` and `crtend.o` version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 ___ cfe-commits mailing

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek updated this revision to Diff 193733. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ https://reviews.llvm.org/D59264 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/Inputs/resource_dir/lib/linux/clang_rt.crtbegin-i386.o clang/test/Driver/Inputs/resourc

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek added a comment. In D59264#1428785 , @MaskRay wrote: > > A nonzero __dso_handle has to match the value passed to __cxa_atexit but a > > zero __dso_handle matches every function registered. So it matters that DSO > > fini calls use &__dso_handle to

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay added a comment. > A nonzero __dso_handle has to match the value passed to __cxa_atexit but a > zero __dso_handle matches every function registered. So it matters that DSO > fini calls use &__dso_handle to match their registrations for the dlclose case Yes, but this won't matter if we c

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

manojgupta added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:447 const char *crtbegin; - if (Args.hasArg(options::OPT_static)) -crtbegin = isAndroid ? "crtbegin_static.o" : "crtbeginT.o"; - else if (Args.hasArg(options::OPT_shared)) -

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:447 const char *crtbegin; - if (Args.hasArg(options::OPT_static)) -crtbegin = isAndroid ? "crtbegin_static.o" : "crtbeginT.o"; - else if

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

manojgupta added subscribers: manojgupta, llozano. manojgupta added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:447 const char *crtbegin; - if (Args.hasArg(options::OPT_static)) -crtbegin = isAndroid ? "crtbegin_static.o" : "crtbeginT.o";

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

E5ten added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolChain.getCompilerRTArgString( --

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolCh

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolChain.getCompilerRTArgString(

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolCh

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:563 + crtend = Args.hasArg(options::OPT_shared) || IsPIE || IsStaticPIE ? + "crtend_shared" : "crtend"; + CmdArgs.push_back(ToolChain.getCompilerRTArgString(

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

phosek created this revision. phosek added a reviewer: echristo. Herald added subscribers: cfe-commits, jdoerfert, fedor.sergeev, dberris, srhines. Herald added a project: clang. phosek edited the summary of this revision. When compiler-rt is selected as the runtime library for Linux use its crtb