[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm closed this revision. arsenm added a comment. 4593e4131affa84e61d7b6844be409ba46d29f11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 __

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

thakis added a comment. test fails on win: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/15191/steps/stage%201%20check/logs/stdio CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 __

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 252978. arsenm retitled this revision from "WIP: AMDGPU: Teach toolchain to link rocm device libs" to "AMDGPU: Teach toolchain to link rocm device libs". arsenm edited the summary of this revision. Herald added a subscriber: Anastasia. CHANGES SINCE LAST ACTIO

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 253156. arsenm added a comment. Cleanup wave64 check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 253194. arsenm added a comment. Fix negating backwards logic for default FTZ mode CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/cl

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:264 def err_drv_invalid_malign_branch_EQ : Error< "invalid argument '%0' to -malign-branch=; each element must be one of: %1">; could you please rebase your patch?

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:264 def err_drv_invalid_malign_branch_EQ : Error< "invalid argument '%0' to -malign-branch=; each element must be one of: %1">; yaxunl wrote: > could you please reb

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 254229. arsenm marked an inline comment as done. arsenm added a comment. Rebase again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/includ

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

hliao added a comment. Do we have a better way to avoid adding those empty bitcode files? Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:29 + struct ConditionalLibrary { +SmallString<0> On; +SmallString<0> Off; may need to add `llvm` namespace prefix

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked 2 inline comments as done. arsenm added a comment. In D59321#1955405 , @hliao wrote: > Do we have a better way to avoid adding those empty bitcode files? No, we need the files to exist for tests. This is what existing bitcode link tests do

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:611 def fno_cuda_short_ptr : Flag<["-"], "fno-cuda-short-ptr">; +def rocm_path_EQ : Joined<["--"], "rocm-path=">, Group, + HelpText<"ROCm installation path">; HIP toolchain will als

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

hliao added a comment. In D59321#1955646 , @arsenm wrote: > In D59321#1955405 , @hliao wrote: > > > Do we have a better way to avoid adding those empty bitcode files? > > > No, we need the files to exist for tests.

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 254584. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/Dr

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 254591. arsenm added a comment. Correct group CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 ___ cfe-commits mailing list cfe-