[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-04-05 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. Generally I'm against introducing new style flags or flag options unless a supported style requires it. IMO this increases maintenance burden and can quickly lead to a big space of style flags that contain tricky incompatibilities. CHANGES SINCE LAST ACTION https://

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-04-05 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:411 * ``SIS_Always`` (in configuration: ``Always``) -Allow short if statements even if the else is a compound statement. +Allow short if/else if/else statements when they are not compoun

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-04-09 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound statement. + MyDeveloperDay wrote: > klimek w

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-03-15 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, reuk, JonasToth, alexfh, krasimir, russellmcc. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: jdoerfert. An addendum to D59087: [clang-format] [PR25010] AllowShortIfStatementsOn

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-03-20 Thread Manuel Klimek via Phabricator via cfe-commits
klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound statement. + I'd try to make this either unco

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-03-20 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound state

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

2019-03-24 Thread Ronald Wampler via Phabricator via cfe-commits
rdwampler added inline comments. Comment at: clang/include/clang/Format/Format.h:264 +/// If Else statements have no braces don't put them +/// on the same line. +/// \code These comments can be used to auto generate the corresponding sections in cla