[PATCH] D60055: Check i < FD->getNumParams() before querying

This revision was automatically updated to reflect the committed changes. Closed by commit rC358134: Check i FD-getNumParams() before querying (authored by gribozavr, committed by ). Changed prior to commit: https://reviews.llvm.org/D60055?vs=194152=194581#toc Repository: rC Clang CHANGES

[PATCH] D60055: Check i < FD->getNumParams() before querying

gribozavr added a comment. I'd be happy to land it, but I do want @rsmith to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. Thanks. Can you land it for me? I'm a newcommer without landing privilege. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___

[PATCH] D60055: Check i < FD->getNumParams() before querying

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. This fix makes sense to me, however, Richard Smith @rsmith is the best person to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. In D60055#1459602 , @lebedev.ri wrote: > I won't be able to properly review this, sorry. Can you suggest someone with familiarity for this part of code? The reviewers I randomly added by `git blame` doesn't seem to be reviewing.

[PATCH] D60055: Check i < FD->getNumParams() before querying

lebedev.ri resigned from this revision. lebedev.ri added a comment. I won't be able to properly review this, sorry. While i'm sure this fix silences the assert, i don't know what that means for the original caller. Does it fail? Does it retry in some other scope? Should it be more picky about

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet marked 2 inline comments as done. Violet added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2895 // function and isn't necessarily referring to one of FD's parameters. - if (FD->getParamDecl(i) == PV) + if (i <

[PATCH] D60055: Check i < FD->getNumParams() before querying

lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2895 // function and isn't necessarily referring to one of FD's parameters. - if (FD->getParamDecl(i) == PV) + if (i < FD->getNumParams() && FD->getParamDecl(i) == PV)

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 194152. Violet added a comment. Address reviewer comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D60055: Check i < FD->getNumParams() before querying

lebedev.ri added inline comments. Comment at: clang/test/SemaCXX/PR41139.cpp:3 + +// expected-no-diagnostics + Add a comment what this test does? ('just checking that the crash does not happen again') Comment at:

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. PING ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193045. Violet added a comment. a more straightforward testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet updated this revision to Diff 193041. Violet added a comment. Wrong bug number Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60055/new/ https://reviews.llvm.org/D60055 Files: clang/lib/Sema/SemaTemplateInstantiate.cpp

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As was already stated in a previous comment, the parameter isn't necessarily referring to one of the DeclContext's parameter. We should check the index is within the range to avoid out-of-boundary