vsk marked an inline comment as done.
vsk added inline comments.
Comment at: test/CodeGenObjCXX/os_log.mm:3
+// RUN: -fexceptions -fcxx-exceptions -O1 | FileCheck %s
+
+// Check that no EH cleanup is emitted around the call to __os_log_helper.
ahatanak wrote:
>
ahatanak added inline comments.
Comment at: test/CodeGenObjCXX/os_log.mm:3
+// RUN: -fexceptions -fcxx-exceptions -O1 | FileCheck %s
+
+// Check that no EH cleanup is emitted around the call to __os_log_helper.
Sorry for the late feedback.
Can we pass `-O0` in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC357501: [os_log] Mark os_log_helper `nounwind` (authored by
vedantk, committed by ).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D60108?vs=193217&id=193322#toc
Repo
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60108/new/
https://reviews.llvm.org/D60108
___
cfe-commits mailing list
c
vsk created this revision.
vsk added reviewers: ahatanak, JDevlieghere.
Herald added subscribers: jdoerfert, dexonsmith.
Allow the optimizer to remove unnecessary EH cleanups surrounding calls
to os_log_helper, to save some code size.
As a follow-up, it might be worthwhile to add a BasicNoexcept
