[PATCH] D60120: check-clang-tools: Actually build and run XPC test

2019-04-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE357719: check-clang-tools: Actually build and run XPC test (authored by nico, committed by ). Herald added a project: clang. Changed prior to commit:

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

2019-04-04 Thread Jan Korous via Phabricator via cfe-commits
jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

2019-04-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. erik.pilkington, could you stamp this maybe? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

2019-04-03 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

2019-04-02 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. (I noticed this while working on D60130 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

2019-04-02 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added reviewers: jkorous, arphaman. Herald added subscribers: kadircet, dexonsmith, ioeric, ilya-biryukov, mgorny. The CMake variable controlling if XPC code is built is called `CLANGD_BUILD_XPC` but three places unintentionally checked the non-existent