[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall closed this revision. rjmccall added a comment. Committed as r358132. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 ___ cfe-commits mailing list

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato added a comment. Oh, and in case I need to mention this (I don't contribute to llvm/clang frequently), I don't have commit access so I'll need someone else to merge it in. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato marked 2 inline comments as done. allevato added a comment. Thanks for the review! This is ready to go on my end if there aren't any other comments. Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:845 + // actually use them (it overwrites them with the

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato updated this revision to Diff 194530. allevato added a comment. - Rename generate* to get* and cleanup param names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 Files:

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

ahatanak added a comment. Just one minor comment, but otherwise the patch looks good to me. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:92 +llvm::Function *generateNonTrivialCStructDefaultConstructor(CodeGenModule , +

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall added a reviewer: ahatanak. rjmccall added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:140 +QualType QT); + } // end namespace CodeGen

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato updated this revision to Diff 194379. allevato added a comment. - Apply review changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 Files: clang/include/clang/CodeGen/CodeGenABITypes.h

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93 +llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst, +CharUnits Alignment, QualType QT); + rjmccall wrote: > Hmm. I think it might be better to just have

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:93 +llvm::BasicBlock::iterator InsertPoint, llvm::Value *Dst, +CharUnits Alignment, QualType QT); + Hmm. I think it might be better to just have this return a

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato created this revision. allevato added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This change exposes the helper functions that generate ctors/dtors for non-trivial structs so that they can be called from the Swift compiler (see