[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

MyDeveloperDay added a comment. Possible fix for PR43372 (https://bugs.llvm.org/show_bug.cgi?id=43372) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 ___ cfe-commits mailing

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

This revision was automatically updated to reflect the committed changes. Closed by commit rC357599: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK (authored by krasimir, committed by ). Changed prior to commit:

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir updated this revision to Diff 193500. krasimir added a comment. - Address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60199/new/ https://reviews.llvm.org/D60199 Files: lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

ioeric added inline comments. Comment at: unittests/Format/SortIncludesTest.cpp:28 std::string sort(StringRef Code, std::vector Ranges, + llvm::Optional ExpectedNumRanges = llvm::None, StringRef FileName = "input.cc") {

[PATCH] D60199: [clang-format] Do not emit replacements while regrouping if Cpp includes are OK

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir added a reviewer: ioeric. Currently clang-format would always emit a replacement for multi-block #include sections if `IBS_Regroup`, even if the sections are correct: % cat ~/test.h