3nids added a comment.
Hi there, is there anything we can do to help this to go through?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60225/new/
https://reviews.llvm.org/D60225
___
cfe-commits mailing list
MyDeveloperDay added a comment.
It was more about not having time to pursue it at this time.. I didn't feel I
should hog the PR if someone else wanted to take a look.
Even though its "Abandoned" it can be brought back at anytime, I don't like to
sit on reviews for too long as it doesn't show
3nids added a comment.
Hi, may I ask why this is abandoned?
We are eagerly waiting on this to move to clang-format.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60225/new/
https://reviews.llvm.org/D60225
___
reuk added inline comments.
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2009
+ // classes case
+ if (Style.AccessModifierIndentation && Line->Level % 2 == 0)
+--Line->Level;
klimek wrote:
> What if the class starts at level 1? (for example, inside
klimek added inline comments.
Comment at: clang/include/clang/Format/Format.h:50
struct FormatStyle {
+ /// Indents after access modifiers. i.e.
+ /// \code
I think we need to explain this a bit more:
What this does is:
Indent classes with access modifiers at
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: klimek, djasper, JonasToth, russellmcc, reuk.
MyDeveloperDay added a project: clang-tools-extra.
Code::Blocks and Qt Creator code uses a style guide which recommends indenting
the next line after the access modifier e.g.
