This revision was automatically updated to reflect the committed changes.
Closed by commit rL357713: Verify that Android targets generate DWARF 4 by
default. (authored by srhines, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Good catch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60238/new/
https://reviews.llvm.org/D60238
srhines marked an inline comment as done.
srhines added inline comments.
Comment at: clang/test/Driver/debug-options.c:280
// G_STANDALONE: "-debug-info-kind=standalone"
+// G_DWARF2: "-dwarf-version=2"
// G_DWARF4: "-dwarf-version=4"
aprantl wrote:
> What's
aprantl added inline comments.
Comment at: clang/test/Driver/debug-options.c:280
// G_STANDALONE: "-debug-info-kind=standalone"
+// G_DWARF2: "-dwarf-version=2"
// G_DWARF4: "-dwarf-version=4"
What's that for?
Repository:
rG LLVM Github Monorepo
CHANGES
srhines created this revision.
srhines added a reviewer: aprantl.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
srhines added subscribers: pirama, chh.
In the future, Android releases will support DWARF 5, but we need to
ensure that older targets only have DWARF 4
