[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk closed this revision. reuk added a comment. Closed by https://reviews.llvm.org/rG91f60b44958f, https://reviews.llvm.org/rL357908, https://reviews.llvm.org/rC357908 (sorry, I forgot to update the body of the commit message to close this automatically) CHANGES SINCE LAST ACTION

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

klimek accepted this revision. klimek added a comment. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk updated this revision to Diff 194057. reuk added a comment. Fixed formatting nit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (minor nit) Comment at: clang/lib/Format/TokenAnnotator.cpp:2834 } - if (Left.is(TT_UnaryOperator)) -return Right.is(TT_BinaryOperator); + if

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. In D60320#1457568 , @reuk wrote: > I updated `ClangFormatStyleOptions.rst` by hand, is there a way to do that > automatically instead (for future patches)? I do it by hand, I know there is a python script out there, go

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk added a comment. I updated `ClangFormatStyleOptions.rst` by hand, is there a way to do that automatically instead (for future patches)? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 ___

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk updated this revision to Diff 194055. reuk added a comment. Updated with fixes. Thanks for pointing out that the options are ordered alphabetically, I hadn't noticed that! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 Files:

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. I actually also tend to change doc/ClangFormatStyleOptions.rst too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 ___ cfe-commits mailing list

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

MyDeveloperDay added a comment. just a few nits, apart form that it LG Comment at: clang/include/clang/Format/Format.h:1721 + /// Defines whether a space should be placed after a logical `!` + bool SpaceAfterLogicalNot; nit: end the sentence with a "."

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk updated this revision to Diff 193889. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60320/new/ https://reviews.llvm.org/D60320 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D60320: [clang-format]: Add option to insert space after locical not operator

reuk created this revision. reuk added reviewers: MyDeveloperDay, klimek. reuk added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch aims to support the following rule from the Juce coding standards