[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

fhahn added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60516/new/ https://reviews.llvm.org/D60516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

tejohnson added a comment. LGTM with a minor fix needed below. Darwin still uses the old LTO API, which is why the lto Config based handling in the new LTO API (LTO.h/LTO.cpp) are not being used on this path. Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:101 +"lto-stats-f

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM with one additional small comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60516/new/ https://reviews.llvm.org/D60516 __

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

steven_wu added a comment. forgot to save the inline comments. Comment at: llvm/lib/LTO/LTOCodeGenerator.cpp:601 // If statistics were requested, print them out after codegen. - if (llvm::AreStatisticsEnabled()) + if (llvm::AreStatisticsEnabled() && !StatsFile) llvm::

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

fhahn marked 2 inline comments as done. fhahn added a comment. In D60516#1470518 , @tejohnson wrote: > LGTM with a minor fix needed below. > > Darwin still uses the old LTO API, which is why the lto Config based handling > in the new LTO API (LTO.h/LTO.cp

[PATCH] D60516: [LTO] Add plumbing to save stats during LTO on Darwin.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358753: [LTO] Add plumbing to save stats during LTO on Darwin. (authored by fhahn, committed by ). Changed prior to commit: https://reviews.llvm.org/D60516?vs=194524&id=195873#toc Repository: rL LLVM