[PATCH] D60674: [X86] Restore the pavg intrinsics.

2019-04-15 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Okay, thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews.llvm.org/D60674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D60674: [X86] Restore the pavg intrinsics.

2019-04-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D60674#1467349 , @efriedma wrote: > > Though I modified the avx512 intrinsics to not have masking built in. > > Do we need autoupgrade support from the old avx512 intrinsics to the new > avx512 intrinsics? Yes, and the c

[PATCH] D60674: [X86] Restore the pavg intrinsics.

2019-04-15 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Though I modified the avx512 intrinsics to not have masking built in. Do we need autoupgrade support from the old avx512 intrinsics to the new avx512 intrinsics? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews

[PATCH] D60674: [X86] Restore the pavg intrinsics.

2019-04-15 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL358427: [X86] Restore the pavg intrinsics. (authored by ctopper, committed by ). Changed prior to commit: https://reviews.llvm.org/D60674?vs=195090&id=195219#toc Repository: rL LLVM CHANGES SINCE LA

[PATCH] D60674: [X86] Restore the pavg intrinsics.

2019-04-15 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - there's too many different optimizations and canonicalizations that can occur on such a pattern to be able to match all of the permutations. We can probably add some InstCombine optim

[PATCH] D60674: [X86] Restore the pavg intrinsics.

2019-04-14 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 195090. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add the clang changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews.l