[PATCH] D61173: [BPF] do not generate predefined macro bpf

2019-04-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL359310: [BPF] do not generate predefined macro bpf (authored by yhs, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61173: [BPF] do not generate predefined macro bpf

2019-04-26 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. shipit Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61173/new/

[PATCH] D61173: [BPF] do not generate predefined macro bpf

2019-04-26 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 196799. yonghong-song edited the summary of this revision. yonghong-song added a comment. remove __bpf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61173/new/ https://reviews.llvm.org/D61173 Files:

[PATCH] D61173: [BPF] do not generate predefined macro bpf

2019-04-26 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: lib/Basic/Targets/BPF.cpp:23 MacroBuilder ) const { - DefineStd(Builder, "bpf", Opts); + Builder.defineMacro("__bpf"); +

[PATCH] D61173: [BPF] do not generate predefined macro bpf

2019-04-26 Thread Alexei Starovoitov via Phabricator via cfe-commits
ast added inline comments. Comment at: lib/Basic/Targets/BPF.cpp:23 MacroBuilder ) const { - DefineStd(Builder, "bpf", Opts); + Builder.defineMacro("__bpf"); + Builder.defineMacro("__bpf__"); I don't think anyone is using

[PATCH] D61173: [BPF] do not generate predefined macro bpf

2019-04-25 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added a project: clang. Herald added a subscriber: cfe-commits. "DefineStd(Builder, "bpf", Opts)" generates the following three macros: bpf __bpf __bpf__ and the macro "bpf" is due to the fact that the target