[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall added a comment. So, apologies everyone for the trouble caused by this patch, and thanks for all the information. It was a mistake to try to change so many things at once. I'll switch the layout back as far as possible while preserving the directory structure. This is a frustrating

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

dyung added a comment. In D61187#1486249 , @probinson wrote: > FYI, we had to disable clangd entirely after this patch, getting a weird > problem with lit that we haven't figured out yet. > In case anybody else has seen something like this, and knows

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

probinson added a comment. FYI, we had to disable clangd entirely after this patch, getting a weird problem with lit that we haven't figured out yet. In case anybody else has seen something like this, and knows what's going on, please let us know. Running all regression tests

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added a comment. In case anyone else runs into this: When doing incremental builds, the old ClangdTests binary stays around in `./tools/clang/tools/unittests/clangd` and is still run by `check-clang-tools`. In case you don't want that (it makes the old test target slower; or maybe your

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. sammccall wrote: > MaskRay wrote: > > thakis wrote: > > > thakis

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. MaskRay wrote: >

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

MaskRay added inline comments. Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. thakis wrote: > thakis wrote: > > Every other LLVM project puts the

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/test/CMakeLists.txt:5 + # No tests for these, but we should still make sure they build. + clangd-indexer + dexp Since you're touching this anyway, there's now one test that calls

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added inline comments. Comment at: clang-tools-extra/trunk/clangd/unittests/lit.cfg.in:1 +@LIT_SITE_CFG_IN_HEADER@ +# This is a shim to run the gtest unittests in ../unittests using lit. thakis wrote: > Every other LLVM project puts the lit.cfg.in for the

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

thakis added a comment. I'm confused by some of the decisions made in this change, see below. Comment at: clang-tools-extra/trunk/clangd/test/lit.cfg.in:29 + config.available_features.add('clangd-xpc-support') + trailing newline Comment at:

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

jkorous added a comment. Patch with fix for XPC tests https://reviews.llvm.org/D61271 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 ___ cfe-commits mailing list

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

jkorous added a comment. @MaskRay @juliehockett I'll take a look. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

juliehockett added a comment. This is also making our Mac builders fail on configuration, and looks like a directory wasn't included properly when a test moved to a subdirectory -- would you mind taking a look? The CMake command we're running is at the top of the attached log. CMake Error

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

MaskRay added a comment. @arphaman @jkorous @thakis I committed https://reviews.llvm.org/rL359428 to fix the following build error. Can one of you check if the test is still built? Thanks! (I don't have a Mac...) if config.clangd_xpc_support: AttributeError:

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

This revision was automatically updated to reflect the committed changes. Closed by commit rL359424: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

ilya-biryukov added a comment. For the record: the tests pass in the shared build configuration. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 ___ cfe-commits

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall added a comment. Also for the record, none of the buildbots in zorg mention check-clang-tools. Bots run tests by enabling clang-tools-extra and then `check-all`, so this patch shouldn't change their behavior. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall updated this revision to Diff 197058. sammccall added a comment. Zap test/Unit directory, put lit.cfg in unittests directly. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 Files: CMakeLists.txt

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall added a comment. Herald added a subscriber: ormris. @ilya-biryukov Can you check this with a shared library build? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall created this revision. sammccall added a reviewer: gribozavr. Herald added subscribers: cfe-commits, jfb, kadircet, arphaman, jkorous, MaskRay, javed.absar, mgorny. Herald added a project: clang. sammccall added a comment. Herald added a subscriber: ormris. @ilya-biryukov Can you check