[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

This revision was automatically updated to reflect the committed changes. Closed by commit rL361691: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support… (authored by ctopper, committed by ). Herald added a subscriber: qcolombet. Changed prior to commit:

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. In D61472#1516642 , @craig.topper wrote: > In D61472#1515994 , @spatel wrote: > > > I haven't looked closely

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. In D61472#1515994 , @spatel wrote: > I haven't looked closely at the series of transforms that gets us here, so > let me ask: would it be more efficient to produce the add/inc/dec machine > instructions directly rather than

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

spatel added a comment. I haven't looked closely at the series of transforms that gets us here, so let me ask: would it be more efficient to produce the add/inc/dec machine instructions directly rather than LEA? Or do we do this because the 3-address opportunity helps register allocation, so

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper updated this revision to Diff 198303. craig.topper added a comment. Get rid of clang stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 Files: llvm/lib/Target/X86/X86FixupLEAs.cpp llvm/test/CodeGen/X86/GlobalISel/add-ext.ll

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper added a comment. Not sure. I'll fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

RKSimon added a comment. Where did all the clang diffs come from? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472 ___ cfe-commits mailing list

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper updated this revision to Diff 198220. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472