This revision was automatically updated to reflect the committed changes.
Closed by commit rC360202: [analyzer] Fix a crash when doing RVO from within
blocks. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D61545?vs=198535=198555#toc
Repository:
rC
dcoughlin accepted this revision.
dcoughlin added a comment.
Looks good to me.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61545/new/
https://reviews.llvm.org/D61545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ updated this revision to Diff 198535.
NoQ added a comment.
Remove unused declaration from the test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61545/new/
https://reviews.llvm.org/D61545
Files:
clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
NoQ updated this revision to Diff 198342.
NoQ added a comment.
No, this is all wrong. We shouldn't unwrap to the parent stack frame here. We
should end up exactly in the location context in which the call has happened.
But we should still unwrap the block invocation context, as an exception,
Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
I think the entire `LocationContext` stuff is a huge design issue, and you used
its functionality without any hack. If you would rename the `getStackFrame` to
`getNextStackFrame` or
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs,
mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet.
Herald added a project: clang.
While blocks are an Apple extension to
