[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

This revision was automatically updated to reflect the committed changes. Closed by commit rL363855: [clang] Adapt ASTMatcher to explicit(bool) specifier (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 205645. Tyker marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61552/new/ https://reviews.llvm.org/D61552 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST/DeclCXX.h clang/include/clang/ASTMatch

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9. +AST_POLYMORPHIC_MATCHER(isExplicit, AST_

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9. +AST_POLY

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a documentation nit. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6190 +/// cxxDeductionGuideDecl(isExplicit()) will match #6, but not #5. +/// cxxConstructorDecl(isExplicit()) will match #8, but not #7 or #9. +AST_POLYMORPHIC_MATCHER(isExplicit, AST_POLYMORP

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 205602. Tyker added a comment. i was confuse because the log seemed like an error and it was happening in python2.7 and python3.7 but the actual error that was preventing generating the documentation only occurs in 3.7. it works in python2.7. CHANGES SINCE

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

aaron.ballman added a comment. In D61552#1550080 , @Tyker wrote: > fixed requested changes. > > > Are you getting errors from running it, or just incorrect output? > > the issue happens to me even on master so i suppose the input is correct. > here is the

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 205559. Tyker marked 3 inline comments as done. Tyker added a comment. fixed requested changes. > Are you getting errors from running it, or just incorrect output? the issue happens to me even on master so i suppose the input is correct. here is the error repo

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

aaron.ballman added a comment. In D61552#1530730 , @Tyker wrote: > i didn't manage to get "clang/docs/tools/dump_ast_matchers.py" to work. it > keep failing to parse and generating empty files as a result. Are you getting errors from running it, or just

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker updated this revision to Diff 203115. Tyker marked an inline comment as done. Tyker edited the summary of this revision. Tyker added a comment. changed as requested. hasExplicitSpecifier now gives access to the expression if present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. You should also regenerate the documentation by running clang/docs/tools/dump_ast_matchers.py. Comment at: clang/include/clang/ASTMatchers/ASTMatcher

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

rsmith added a comment. This seems reasonable to me, but I'll leave it to @klimek or someone else to judge whether the `isExplicit` / `hasExplicitSpecifier` approach is the right way to expose this functionality to matcher users. Repository: rC Clang CHANGES SINCE LAST ACTION https://revi

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

Tyker created this revision. Tyker added a reviewer: klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changes: - add an ast matcher for deductiong guide. - allow isExplicit matcher for deductiong guide. - add hasExplicitSpecifier matcher which matches for declaration