mibintc abandoned this revision.
mibintc added a comment.
I'll modify this to be a cc1 only option, there doesn't seem to be community
interest.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61743/new/
https://reviews.llvm.org/D61743
___
mibintc added a comment.
@rjmccall Can you take a look at this patch or recommend someone who can review
it? Many thanks. --Melanie
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61743/new/
https://reviews.llvm.org/D61743
___
cfe-commits
mibintc added a comment.
@dexonsmith Can you take a look at this patch or recommend someone who can
review it? Many thanks. --Melanie
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61743/new/
https://reviews.llvm.org/D61743
___
mibintc updated this revision to Diff 199082.
mibintc added a comment.
respond to suggestion from @xbolva00 (thanks). Added a test case where prefix
fails to match
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61743/new/
https://reviews.llvm.org/D61743
Files:
xbolva00 added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:279
+ if (DependencyFilter.size() &&
+ strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) ==
0)
+// Remove dependencies that are prefixed by the Filter string.
xbolva00 added inline comments.
Comment at: lib/Frontend/DependencyFile.cpp:279
+ if (DependencyFilter.size() &&
+ strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) ==
0)
+// Remove dependencies that are prefixed by the Filter string.
mibintc marked an inline comment as done.
mibintc added a comment.
added an inline comment about the use of strncmp
Comment at: lib/Frontend/DependencyFile.cpp:279
+ if (DependencyFilter.size() &&
+ strncmp(Filename, DependencyFilter.c_str(), DependencyFilter.size()) ==
mibintc created this revision.
mibintc added reviewers: clang-c, fedor.sergeev.
mibintc added a project: clang.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Intel is developing an offload compiler based on clang (that will eventually be
contributed to open source). In