Re: [PATCH] D61914: [Support][Test] Time profiler: add regression test

--target= Sent from ProtonMail Mobile On Fri, Jun 7, 2019 at 2:01 PM, Anton Afanasyev via Phabricator wrote: > anton-afanasyev marked an inline comment as done. > anton-afanasyev added a comment. > > In D61914#1534508 , @plotfi wrote: > >>

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev marked an inline comment as done. anton-afanasyev added a comment. In D61914#1534508 , @plotfi wrote: > cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you > mean to pass the target explicitly ? This commit is

[PATCH] D61914: [Support][Test] Time profiler: add regression test

plotfi added inline comments. Comment at: cfe/trunk/test/Driver/check-time-trace.cpp:1 +// RUN: %clangxx -ftime-trace %s 2>&1 | grep "Time trace json-file dumped to" \ +// RUN: | awk '{print $NF}' | xargs cat \ This test should probably have // REQUIRES: shell

[PATCH] D61914: [Support][Test] Time profiler: add regression test

plotfi added a comment. cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you mean to pass the target explicitly ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914

[PATCH] D61914: [Support][Test] Time profiler: add regression test

This revision was automatically updated to reflect the committed changes. Closed by commit rL362792: [Support][Test] Time profiler: add regression test (authored by anton-afanasyev, committed by ). Changed prior to commit: https://reviews.llvm.org/D61914?vs=203532=203544#toc Repository: rL

[PATCH] D61914: [Support][Test] Time profiler: add regression test

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. Thanks Anton! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev updated this revision to Diff 203532. anton-afanasyev marked 2 inline comments as done. anton-afanasyev added a comment. Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61914/new/ https://reviews.llvm.org/D61914 Files:

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev marked 4 inline comments as done. anton-afanasyev added a comment. In D61914#1512021 , @aganea wrote: > Could you please move the test to a more approriate location? (ie. > clang/trunk/test/Driver/) Thanks, I've moved it there.

[PATCH] D61914: [Support][Test] Time profiler: add regression test

aganea added a comment. Could you please move the test to a more approriate location? (ie. clang/trunk/test/Driver/) Comment at: clang/tools/driver/cc1_main.cpp:245 + +llvm::errs() << "Time trace json-file dumped to " << Path.str() << "\n"; +llvm::errs()

[PATCH] D61914: [Support][Test] Time profiler: add regression test

anton-afanasyev created this revision. anton-afanasyev added a reviewer: thakis. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Add output to `llvm::errs()` when `-ftime-trace` option is enabled, add regression test checking this option works as expected.