t.p.northover marked an inline comment as done.
t.p.northover added a comment.
Thanks for the suggestion Florian, and sorry it's taken so long to act on it.
I've split the patch up as you suggest, I'll make this one cover the Triple
bits.
Comment at:
t.p.northover updated this revision to Diff 204009.
t.p.northover added a comment.
This diff now only covers the trivial additions so that "arm64_32" is
understood by the driver and creates AArch64 instantiations of relevant
classes. Code generated is still wildly incorrect (not even ILP32
fhahn added a comment.
Hi Tim. Would it be possible to split this in the 'trivial' changes (extending
the triple handling for example) and the arm64_32 related changes to size, ABI
stuff and so on? The trivial changes look good to me and by splitting them off
people can focus on reviewing the
t.p.northover added a comment.
Ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61939/new/
https://reviews.llvm.org/D61939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
t.p.northover added a comment.
Oops, yes. I'll leave it wrong though, the best that could come out of any
attempt to change it would be to split the thread on llvm-commits.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61939/new/
https://reviews.llvm.org/D61939
lebedev.ri added a comment.
The subject has a typo, 23 instead of 32 ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61939/new/
https://reviews.llvm.org/D61939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
t.p.northover updated this revision to Diff 200707.
t.p.northover added a comment.
During upstreaming we've changed from detecting an "arm64_32" ArchName to using
a Triple::aarch64_32 Arch. We recently discovered a bug that meant only AArch32
NEON types were permitted, which is fixed in this
t.p.northover created this revision.
Herald added subscribers: jfb, kristof.beyls, javed.absar, mcrosier.
Herald added a project: clang.
This patch implements the arm64_32 ABI used in watchOS from the Clang side.
It's mostly pretty straightforward since it's so close to normal AArch64:
handle
