modocache abandoned this revision.
modocache added a comment.
I'm not super interested in this patch anymore, someone else feel free to work
on this! :)
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62035/new/
https://reviews.llvm.org/D62035
jyknight added a comment.
I don't really have much to say about this, and the patch is probably fine, but
I do note that most of the other accessors on this class also return mutable
objects.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62035/new/
beng added a comment.
Thanks! @jyknight might want to take a look (this seems fine to me though).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62035/new/
https://reviews.llvm.org/D62035
___
cfe-commits mailing list
adamjernst added a comment.
@beng (hello!!) I've spotted you reviewing some Objective-C clang stuff … can
you review, or do you have advice on a qualified reviewer?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62035/new/
https://reviews.llvm.org/D62035
modocache created this revision.
modocache added a reviewer: rjmccall.
Herald added a project: clang.
When writing an AST matcher to find inherited Objective-C classes, I
noticed the returned `ObjCInterfaceDecl*` was mutable. It doesn't seem
like it needs to be mutable, so this patch makes it
