[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 200637. yaqiji edited the summary of this revision. yaqiji added a comment. Removed other mdodified file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore marked 2 inline comments as done. stephanemoore added a comment. (sorry I forgot to send this earlier) Two small things and then I think everything is good. Comment at: clang-tools-extra/clang-tidy/google/GlobalVariableDecla

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201352. yaqiji marked 3 inline comments as done. yaqiji added a comment. Added fix message, and change global to nonstatic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D6204

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore added a comment. Looks good! Thanks for being patient with me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 _

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji added a comment. Thank you so much for reviewing the code and providing great feedbacks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 ___ cfe-commits

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore added a comment. It looks like all concerns have been addressed. Do you need me to land this commit for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji added a comment. Yes please, thank you :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361907: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore, committed by ). Changed prior to commit: https://reviews.llvm.org/D62045?vs=201352&id=2

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore reopened this revision. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/google-objc-global-variable-declaration.m:48 static NSString* gMyIntGood = 0; +extern NSString* Y2Good; Whoo

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201968. yaqiji added a comment. Updated warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201969. yaqiji added a comment. Added check-fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201972. yaqiji added a comment. Remove cmake content Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarati

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201971. yaqiji added a comment. Removed check-fixes for those without fixithint. Changed name of Y2Good to Y2Bad to match meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.o

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201973. yaqiji added a comment. Added to check no fixit is generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/Global

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore accepted this revision. stephanemoore marked an inline comment as done. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/google-objc-global-variable-declaration.m:46 +// CHECK-MESSAG

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362279: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chan

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

gribozavr added a comment. Sorry for jumping in late, but renaming the declaration is not enough -- usages should also be updated; otherwise the developer is better off using a refactoring in their IDE or even a textual search and replace. Repository: rL LLVM CHANGES SINCE LAST ACTION htt