Anastasia marked 2 inline comments as done.
Anastasia added inline comments.
Comment at: test/SemaCXX/address-space-ctor.cpp:11
+//expected-note@-6{{candidate constructor (the implicit move constructor) not
viable: no known conversion from 'int' to 'MyType &&' for 1st
This revision was automatically updated to reflect the committed changes.
Closed by commit rL363944: [Sema] Diagnose addr space mismatch while
constructing objects (authored by stulova, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, LGTM.
Comment at: test/SemaCXX/address-space-ctor.cpp:11
+//expected-note@-6{{candidate constructor (the implicit move constructor) not
viable: no known
Anastasia marked 2 inline comments as done.
Anastasia added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:6095
+// Check that addr space of an object being constructed is convertible to
+// the one ctor qualified with.
+if
Anastasia updated this revision to Diff 202690.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Changed FIXME to a regular comment, modified wording.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62156/new/
https://reviews.llvm.org/D62156
Files:
rjmccall added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:8219
+ // to allow skipping it. However we are not visiting all qual
+ // currently and therefore there is no condition yet.
Diag(SL, diag::err_invalid_qualified_constructor)
Anastasia marked 4 inline comments as done.
Anastasia added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:8229
+ if (FTI.hasMethodTypeCVRUQualifiers()) {
+FTI.MethodQualifiers->forEachCVRUQualifier(
[&](DeclSpec::TQ TypeQual, StringRef QualName,
Anastasia updated this revision to Diff 202193.
Anastasia marked 3 inline comments as done.
Anastasia added a comment.
- Improved diagnostic
- Added more comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62156/new/
https://reviews.llvm.org/D62156
Files:
rjmccall added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:3653
+def note_ovl_candidate_illegal_constructor_adrspace_mismatch : Note<
+"candidate constructor ignored: address space mismatch between object and
constructor">;
def
Anastasia added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:8229
+ if (FTI.hasMethodTypeCVRUQualifiers()) {
+FTI.MethodQualifiers->forEachCVRUQualifier(
[&](DeclSpec::TQ TypeQual, StringRef QualName, SourceLocation SL) {
rjmccall wrote:
>
Anastasia updated this revision to Diff 201228.
Anastasia marked an inline comment as done.
Anastasia added a comment.
- Added candidates as not viable
- Added dedicated diagnostic note
- Added assert
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62156/new/
rjmccall added inline comments.
Comment at: include/clang/Sema/Overload.h:977
+
+void setDestAS(LangAS AS) { DestAS = AS; }
};
Can this assert that `Kind == CSK_InitByConstructor || Kind ==
CSK_InitByUserDefinedConversion`?
Comment at:
12 matches
Mail list logo