[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-25 Thread Wink Saville via Phabricator via cfe-commits
winksaville abandoned this revision. winksaville added a comment. Rather than creating LLVMgold.so as this change does, @beanz suggested we use a known LTO capable linker, `lld`. See D62279 .. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-23 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. In D62215#1512849 , @winksaville wrote: > IIRC, on linux if LTO is ON I had to use `ld.gold` for both stage 1 and 2, > although that maybe > just the way it ended up and it wasn't necessary. But I'll test whatever you > come up wi

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-22 Thread Wink Saville via Phabricator via cfe-commits
winksaville added a comment. > I actually really appreciate you trying this out and reporting back with such > detailed feedback on your experience. Thank you for your patience, and I'm > sorry if I'm being a bit of a pain. Been a good learning experince for me, both LLVM and cmake, I hope you

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-22 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. D62269 should fix the missing dependency on `gtest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62215/new/ https://reviews.llvm.org/D62215 _

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-22 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. In D62215#1512543 , @winksaville wrote: > With this error I guessed that I needed to build `LLVMgold.so`, but then I > also determined > I needed to link everything with `ld.gold` to complete the build process, > which is why I >

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-22 Thread Wink Saville via Phabricator via cfe-commits
winksaville added a comment. In D62215#1510933 , @beanz wrote: > Adding "libcxxabi" to `LLVM_ENABLE_RUNTIMES` is fine, but the other changes > to the DistributionExample are only needed because you chose to use gold, > which is a configuration-specific d

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-21 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. Adding "libcxxabi" to `LLVM_ENABLE_RUNTIMES` is fine, but the other changes to the DistributionExample are only needed because you chose to use gold, which is a configuration-specific decision that is not representative of how most people will build, therefore it shouldn'

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-21 Thread Wink Saville via Phabricator via cfe-commits
winksaville added a comment. This may not "correct" but I had to do these to get `ninja stage2-distribution` to complete on my computer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62215/new/ https://reviews.llvm.org/D62215 __

[PATCH] D62215: Fixes to distribution example for X86_64 Arch Linux

2019-05-21 Thread Wink Saville via Phabricator via cfe-commits
winksaville created this revision. winksaville added a reviewer: beanz. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. Add runtime libcxxabi, use gold linker and create LLVMgold.so. Tested with on monorepo with: mkdir build && cd build && \ cmak