[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke marked an inline comment as done. fanjinke added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; craig.topper wrote: > f

[PATCH] D62368: Add support for Hygon Dhyana processor

craig.topper added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; fanjinke wrote: > craig.topper wrote: > > What's the rationale

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke marked an inline comment as done. fanjinke added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; craig.topper wrote: > W

[PATCH] D62368: Add support for Hygon Dhyana processor

craig.topper added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; What's the rationale for the vendor check here anyway? Why isn

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added a comment. Hi Cryptoad, Thank you so much for your comment. I will divide it into two patches according to your suggestion. Best regards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm.org/D62368

[PATCH] D62368: Add support for Hygon Dhyana processor

cryptoad added a comment. Hey, `clang/lib/Headers/cpuid.h` would have to be in its own CL that would have to be sent separately from the Scudo one. It would have to be reviewed by clang people and likely some tests added. Once this is done and landed, then the Scudo part can happen. Thanks!

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke updated this revision to Diff 259150. fanjinke edited the summary of this revision. fanjinke added a comment. 1，Update patch base on lastest commit e90fb82f0f760703c14eafbad96c08b6019a2f0f . 2，Format the patch with “git

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added a comment. Hi cryptoad， Any suggestions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm.org/D62368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke edited reviewers, added: cryptoad; removed: 01alchemist, 4tXJ7f. fanjinke added a comment. Hi Cryptoad, Thanks for your reminds, and I get the points now. Then updated the scudo part of the patch. After patch update，compiler-rt can be successfully compiled using gcc. Thanks again!

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke updated this revision to Diff 250996. fanjinke added a comment. Results of "make check": Testing Time: 1153.40s Expected Passes: 36042 Expected Failures : 163 Unsupported Tests : 340 [100%] Built target check-llvm Scanning dependencies of target check [100%] Bui

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke added reviewers: 01alchemist, 4tXJ7f. fanjinke added a comment. Hi, Please help with the patch reveiw. Hi cryptoad, @cryptoad IS there anything incorrectly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/ https://reviews.llvm

[PATCH] D62368: Add support for Hygon Dhyana processor

cryptoad added a comment. Regarding the Scudo side of the patch: the code has to be able to compile with gcc as well, and not necessarily the latest version. This won't compile on systems without a `signature_HYGON_*`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke created this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This patch adds vendor id detection for Hygon Dhyana CPUs. More details can be found on: http://lkml.kernel.org/r/5ce86123a7b9dad925ac583d88d2f92104