[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

This revision was automatically updated to reflect the committed changes. Closed by commit rL361809: [clang-tidy] Fix null pointer dereference in readability-identifier-naming (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

hokein accepted this revision. hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), +

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

markstegeman added a comment. Great. Can someone commit this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62404/new/ https://reviews.llvm.org/D62404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { +

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

madsravn added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), + Value->getSourceRange());

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:804 +if (const auto *Typedef = TypePtr->getAs()) { + addUsage(NamingCheckFailures, Typedef->getDecl(), + Value->getSourceRange());

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

markstegeman updated this revision to Diff 201401. markstegeman added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62404/new/ https://reviews.llvm.org/D62404 Files: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

[PATCH] D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming

aaron.ballman added a comment. In D62404#1516243 , @markstegeman wrote: > I haven't yet been able to figure out how to properly add a test for this > bug, since the expected result is a failure to compile while the current >