This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL364866: [analyzer] NFC: Add a convenient CallDescriptionMap
class. (authored by dergachev, committed by ).
Herald added a
NoQ updated this revision to Diff 207403.
NoQ marked 5 inline comments as done.
NoQ added a comment.
Address comments.
Improve the tests so that they failed when not all requested functions were
found - it's pretty crude as it only checks that the number of hits is correct,
but, i guess, that's
NoQ added inline comments.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060
+public:
+ const static unsigned NoArgRequirement =
std::numeric_limits::max();
+
Charusso wrote:
> What about `Optional<>`? When I first met that fun
Charusso accepted this revision.
Charusso added a comment.
Great patch, thanks you! I wanted to make my own `IdentifierInfo` array
previously.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1060
+public:
+ const static unsigned NoArgRequirement
NoQ updated this revision to Diff 206951.
NoQ added a comment.
Indeed. Subtle!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62441/new/
https://reviews.llvm.org/D62441
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
clang/unittests/StaticAnalyzer/CMakeLists
xazax.hun requested changes to this revision.
xazax.hun added inline comments.
This revision now requires changes to proceed.
Comment at:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1088
+ // descriptions (eg., the ones for C functions that just match the
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
This is why I love unit tests so much, you get the learn a lot about how things
work! Thanks!
The idea for the patch is great, can't wait to get rid of the mess we have in
`MallocChecke
NoQ updated this revision to Diff 201382.
NoQ added a comment.
Bring back an assertion in `findNode<>()`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62441/new/
https://reviews.llvm.org/D62441
Files:
clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h
clang/unittest