[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/test/CMakeLists.txt:140 - set_target_properties(check-clang-analyzer PROPERTIES FOLDER "Clang tests") - - if (LLVM_WITH_Z3) thakis wrote: > Did you intentionally

[PATCH] D62445: [test] Fix plugin tests

thakis added inline comments. Comment at: cfe/trunk/test/CMakeLists.txt:140 - set_target_properties(check-clang-analyzer PROPERTIES FOLDER "Clang tests") - - if (LLVM_WITH_Z3) Did you intentionally delete the 2 targets here? Repository: rL LLVM CHANGES

[PATCH] D62445: [test] Fix plugin tests

mikhail.ramalho added a comment. Herald added a subscriber: Charusso. Hi, I just found this revision. Could you point out how can I run the CSA tests with Z3 as backend? We used to do `$ ninja check-clang-analyzer-z3`, however, it now fails and suggests: $ ninja check-clang-analyzer-z3

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1630518 , @NoQ wrote: > I didn't make much progress so far, but i marked the test as `// UNSUPPORTED: > darwin` in rC368765 , so the buildbot is > now green starting with >

[PATCH] D62445: [test] Fix plugin tests

NoQ added a comment. I didn't make much progress so far, but i marked the test as `// UNSUPPORTED: darwin` in rC368765 , so the buildbot is now green starting with http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6519/. Repository: rL LLVM

[PATCH] D62445: [test] Fix plugin tests

davezarzycki added a comment. In D62445#1616218 , @davezarzycki wrote: > Just FYI – Having LLVM_ENABLE_PLUGINS_default depend on LLVM_ENABLE_PIC is a > hack that should go away someday. Doing so requires that plugin dependencies > either always build

[PATCH] D62445: [test] Fix plugin tests

davezarzycki added a comment. Just FYI – Having LLVM_ENABLE_PLUGINS_default depend on LLVM_ENABLE_PIC is a hack that should go away someday. Doing so requires that plugin dependencies either always build PIC (and therefore ignore LLVM_ENABLE_PIC), or are linked into the executables that load

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > It got suddenly fixed in >

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1613268 , @NoQ wrote: > Ugh, there seems to be one more forgotten buildbot with plugins problems: > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText > > FAIL: Clang ::

Re: [PATCH] D62445: [test] Fix plugin tests

Just saw this. I'll take a look, and thanks for pointing it out... On Fri, Aug 2, 2019 at 6:24 PM Artem Dergachev via Phabricator < revi...@reviews.llvm.org> wrote: > NoQ added a comment. > > Ugh, there seems to be one more forgotten buildbot with plugins problems: >

[PATCH] D62445: [test] Fix plugin tests

NoQ added a comment. Ugh, there seems to be one more forgotten buildbot with plugins problems: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/6406/consoleText FAIL: Clang :: Analysis/checker-plugins.c (467 of 14955) TEST 'Clang ::

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) hintonda wrote: > nathanchance wrote: > > I think this should have

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) nathanchance wrote: > I think this should have a dependency on

[PATCH] D62445: [test] Fix plugin tests

nathanchance added inline comments. Comment at: cfe/trunk/lib/Analysis/plugins/CMakeLists.txt:1 +if(LLVM_ENABLE_PLUGINS) + add_subdirectory(SampleAnalyzer) I think this should have a dependency on `CLANG_ENABLE_STATIC_ANALYZER` like in

[PATCH] D62445: [test] Fix plugin tests

hintonda added a comment. In D62445#1527368 , @davezarzycki wrote: > This broke non-PIC builds. Fixed: r362399 Sorry for the breakage, and thanks for the fix! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/

[PATCH] D62445: [test] Fix plugin tests

davezarzycki added a comment. This broke non-PIC builds. Fixed: r362399 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62445: [test] Fix plugin tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL362328: [test] Fix plugin tests (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62445?vs=202573=202605#toc Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62445: [test] Fix plugin tests

hintonda updated this revision to Diff 202573. hintonda added a comment. - Fix dependencies so required plugins get built before tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445 Files:

[PATCH] D62445: [test] Fix plugin tests

hintonda reopened this revision. hintonda added a comment. This revision is now accepted and ready to land. This patch broke some of the bots, so reopening to track the fix. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62445/new/ https://reviews.llvm.org/D62445

[PATCH] D62445: [test] Fix plugin tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC361790: [test] Fix plugin tests (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D62445?vs=201391=201614#toc Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" -

[PATCH] D62445: [test] Fix plugin tests

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang/test/CMakeLists.txt:141-147 - if (LLVM_WITH_Z3) -add_lit_testsuite(check-clang-analyzer-z3 "Running the Clang analyzer tests, using Z3 as a solver" -

[PATCH] D62445: [test] Fix plugin tests

NoQ added subscribers: mikhail.ramalho, ddcc. NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! I think we're losing the Z3 constraint manager test suite this way after all (details inline), but i feel we should downprioritize this when

[PATCH] D62445: [test] Fix plugin tests

hintonda created this revision. hintonda added reviewers: beanz, phosek, george.karpenkov, NoQ, ahatanak, rjmccall. Herald added subscribers: llvm-commits, dexonsmith, mgorny. Herald added projects: clang, LLVM. hintonda edited the summary of this revision. The following changes were required to