[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Superseded by [[ https://reviews.llvm.org/D73720 | [Analyzer] Use note tags to track container begin and and changes ]], [[ https://reviews.llvm.org/D74541 | [Analyzer] Use note tags to track iterator increments and

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. In D62525#1609334 , @NoQ wrote: > Ok, so is it problematic to define a lambda that checks whether an > interesting iterator is invalidated? Or is it difficult to return the note > tag from many stack frames in order

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1495-1496 // For deque-like containers invalidate all iterator positions. For // vector-like containers invalidate iterator positions after the insertion. const auto *Cont =

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

NoQ added a comment. In D62525#1607813 , @Szelethus wrote: > In D62525#1523026 , > @baloghadamsoftware wrote: > > > The problem is that the transition is added in the top level function but > > iterator position

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:281-282 + + // `FoundChange` becomes true when we find the statement the results in the + // current state of the

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

Szelethus added a comment. I don't see obvious red flags here, @NoQ? In D62525#1523026 , @baloghadamsoftware wrote: > In D62525#1519868 , @NoQ wrote: > > > In D62525#1519475

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62525/new/ https://reviews.llvm.org/D62525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1277-1292 +State = setContainerData(State, ContReg, CData->newEnd(OldEndSym)); } else {

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1099 reportOutOfRangeBug("Iterator decremented ahead of its valid range.", LHS, -C, N); +C, N, Pos, false); }

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware updated this revision to Diff 204227. baloghadamsoftware added a comment. Visitors now track increments and decrements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62525/new/ https://reviews.llvm.org/D62525 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:281-282 + + // `FoundChange` becomes true when we find the statement the results in the + // current state of the

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. In D62525#1519868 , @NoQ wrote: > In D62525#1519475 , > @baloghadamsoftware wrote: > > > Before someone asks: `NoteTag`s are not applicable here since invalidation > > and

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

NoQ added a comment. In D62525#1519475 , @baloghadamsoftware wrote: > Before someone asks: `NoteTag`s are not applicable here since invalidation > and reaching one end of the range happens in many different places. This is > also true for container

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. Before someone asks: `NoteTag`s are not applicable here since invalidation and reaching one end of the range happens in many different places. This is also true for container emptiness. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Iterator bugs such as