This revision was automatically updated to reflect the committed changes.
Closed by commit rL363680: [clangd] Add hidden tweaks to dump AST/selection.
(authored by sammccall, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/refactor/Tweak.h:104
+ /// Is this a 'hidden' tweak, which are off by default.
+ virtual bool hidden() const { return false; }
};
ilya-biryukov wrote:
> I wonder wh
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a few NITs
Comment at: clangd/refactor/Tweak.h:104
+ /// Is this a 'hidden' tweak, which are off by default.
+ virtual bool hidden() const { return
sammccall added a comment.
i mean ping
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62538/new/
https://reviews.llvm.org/D62538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
sammccall added a comment.
pind
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62538/new/
https://reviews.llvm.org/D62538
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
sammccall updated this revision to Diff 201765.
sammccall added a comment.
Add DumpRecordLayout. Fix a small SelectionTree bug uncovered by these tweaks.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62538/new/
https://reviews.llvm.org/D62538
Files
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
mgorny.
Herald added a project: clang.
This introduces a few new concepts:
- tweaks have an Intent (they don't all advertise as refactorings)
-
