[PATCH] D62571: Implement codegen for MSVC unions with reference members

aaron.ballman closed this revision. aaron.ballman added a comment. In D62571#1646227 , @domdom wrote: > Rebased onto master, clang format the patch. > > Merge conflict resolve by having the bitcast of the field reference happening > after recording access

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom updated this revision to Diff 217289. domdom added a comment. Rebased onto master, clang format the patch. Merge conflict resolve by having the bitcast of the field reference happening after recording access index. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https:

[PATCH] D62571: Implement codegen for MSVC unions with reference members

aaron.ballman added a comment. In D62571#1642096 , @domdom wrote: > Thanks @aaron.ballman! > > I will need someone to commit this for me :) I'm happy to commit for you, but I get merge conflicts when trying to apply your patch. Can you rebase on trunk?

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom added a comment. Thanks @aaron.ballman! I will need someone to commit this for me :) Cheers, Dom CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https://reviews.llvm.org/D62571 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D62571: Implement codegen for MSVC unions with reference members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! I think this is actually needed to properly support MFC on Windows, IIRC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https://reviews.llvm

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom added a comment. Ping! Cheers, Dom CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https://reviews.llvm.org/D62571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom updated this revision to Diff 205495. domdom added a comment. clang-formatted the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https://reviews.llvm.org/D62571 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGenCXX/ms-union-member-ref.cpp Index: clang/t

[PATCH] D62571: Implement codegen for MSVC unions with reference members

aaron.ballman added reviewers: rnk, majnemer. aaron.ballman added subscribers: majnemer, rnk. aaron.ballman added a comment. This looks reasonable to me, but @rnk and @majnemer may have opinions as well. Comment at: clang/test/CodeGenCXX/ms-union-member-ref.cpp:3-6 +union A { +

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom created this revision. domdom added a reviewer: asl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, clang accepts a union with a reference member when given the -fms-extensions flag. This change fixes the codegen for this case. Repository: rC Clang h