[PATCH] D62611: [analyzer][Dominators] Add unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rL365179: [analyzer][Dominators][NFC] Add unit tests (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D62611: [analyzer][Dominators] Add unittests

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Looks good to me, some nits inline. Comment at: clang/unittests/Analysis/CFGBuildResult.h:1 +//===- unittests/Analysis/CFGTest.cpp - CFG tests

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus updated this revision to Diff 207759. Szelethus added a comment. Fixes according to reviewer comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 Files: clang/unittests/Analysis/CFGBuildResult.h clang/unittests/Analysis/CFGDom

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:22-32 +template struct FindStmt { + bool operator()(const CFGElement &E) { +if (auto S = E.getAs()) + return isa(S->getStmt()); +r

[PATCH] D62611: [analyzer][Dominators] Add unittests

NoQ added inline comments. Comment at: clang/unittests/Analysis/CFGBuilder.h:16 + +class BuildResult { +public: Given that now it's in a header, i guess we need to pick a less generic name. Eg., `CFGBuildResult`. Comment at: clang/unittests/An

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus added a comment. Gentle ping :^) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D62611: [analyzer][Dominators] Add unittests

sanaanajjar231288 added a comment. In D62611#1521692 , @Szelethus wrote: > Fixes according to reviewer comments, thanks! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 __

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62611: [analyzer][Dominators] Add unittests

xazax.hun added a comment. Oh, I realized later that code I commented on were only moved from somewhere else. If you feel like tackling these comments feel free to do so in a separate patch so this one stays clean (no changes to moved code). Comment at: clang/unittests/Analys

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus updated this revision to Diff 202004. Szelethus added a comment. Fixes according to reviewer comments, thanks! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 Files: clang/unittests/Analysis/CFGBuilder.h clang/unittests/Analysis

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95 + CFGPostDomTree PostDom; + PostDom.buildDominatorTree(cfg); + kuhar wrote: > Why not have a constructor that takes the cfg

[PATCH] D62611: [analyzer][Dominators] Add unittests

NoQ added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:37 +TEST(CFGDominatorTree, DomTree) { + const char *Code = "enum Kind {\n" + " A\n" kuhar wrote: > You can use a raw string literal to make it more readable

[PATCH] D62611: [analyzer][Dominators] Add unittests

kuhar added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95 + CFGPostDomTree PostDom; + PostDom.buildDominatorTree(cfg); + Why not have a constructor that takes the cfg and constructs a domtree straight away? But this should proba

[PATCH] D62611: [analyzer][Dominators] Add unittests

kuhar added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:37 +TEST(CFGDominatorTree, DomTree) { + const char *Code = "enum Kind {\n" + " A\n" You can use a raw string literal to make it more readable: https://en

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kuhar, whisperity, mgorny. Ex