[PATCH] D62623: Reduce memory consumption of coverage dumps

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cd07dbeec98: Reduce memory consumption of coverage dumps (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/

[PATCH] D62623: Reduce memory consumption of coverage dumps

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto : CoverageMappings) { +CoverageMappingSize += S.size();

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto : CoverageMappings) { +CoverageMappingSize += S.size(); vsk wrote: > It doesn't look like the CoverageMappings

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille updated this revision to Diff 202896. serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Update comment + force reduced memory consumption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1524666 , @kwk wrote: > In D62623#1522575 , > @serge-sans-paille wrote: > > > @kwk: looks like you're still compiling with clang-7, this patch is to be > > applied on the master

[PATCH] D62623: Reduce memory consumption of coverage dumps

vsk added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1393 + size_t CoverageMappingSize = 0; + for (auto : CoverageMappings) { +CoverageMappingSize += S.size(); It doesn't look like the CoverageMappings std::vector is needed at

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1522575 , @serge-sans-paille wrote: > @kwk: looks like you're still compiling with clang-7, this patch is to be > applied on the master version of LLVM/clang, then you can install it and use > it to recompile llvm/lld

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille added a comment. @kwk: looks like you're still compiling with clang-7, this patch is to be applied on the master version of LLVM/clang, then you can install it and use it to recompile llvm/lld with coverage info. Does it make sense to you? Repository: rG LLVM Github

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. In D62623#1521999 , @kwk wrote: > @serge-sans-paille testing it now. Unfortunately, the error for me is similar (or the same) to before; [692/2860] Building CXX object

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. @serge-sans-paille testing it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/ https://reviews.llvm.org/D62623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille created this revision. serge-sans-paille added reviewers: vsk, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. serge-sans-paille edited the summary of this revision. Avoiding an intermediate join operation, which in turns removes the