[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added a comment. In D62638#1529170 , @krytarowski wrote: > This commit breaks the NetBSD buildbot node. rC362574 . Comment at:

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. Thanks!! Will fix as soon as i get to my desktop. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: cfe/trunk/utils/analyzer/exploded-graph-rewriter.py:1 +#!/usr/bin/env python + ``` # something else then # #==- exploded-graph-rewriter.py - Simplifies the ExplodedGraph -*- python -*-==# # # Part of the LLVM Project,

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

krytarowski added a comment. This commit breaks the NetBSD buildbot node. http://lab.llvm.org:8011/builders/netbsd-amd64/builds/20359 The problem is that this patch hardcodes python specific binary name, while it has to be detected dynamically or ideally passed from CMake. Afair lit has a

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. I disabled tests on Windows for now (rC362343 -> rC362347 ), but other than that the tests are working well, there was nothing to worry about. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362340: [analyzer] exploded-graph-rewriter: Initial commit. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Let us see those tests! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202511. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot clang/test/Analysis/exploded-graph-rewriter/empty.dot

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json)

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json) NoQ wrote: > Charusso

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json)

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. In D62638#1525843 , @Charusso wrote: > In D62638#1525823 , @NoQ wrote: > > > Also switched to python2 because it seems to be the default. The > > differences are minimal. > > > What about the

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added a comment. In D62638#1525823 , @NoQ wrote: > Also switched to python2 because it seems to be the default. The differences > are minimal. What about the state of the patch itself? Planned stuff WIP, could I take it to SVGify, or?

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:151 +super(ExplodedGraph, self).__init__() +self.nodes = collections.defaultdict(ExplodedNode) +self.root_id = None NoQ wrote: > Charusso wrote: >

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:151 +super(ExplodedGraph, self).__init__() +self.nodes = collections.defaultdict(ExplodedNode) +self.root_id = None Charusso wrote: > `nodes` ->

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. Also switched to python2 because it seems to be the default. The differences are minimal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mailing list

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202502. NoQ marked 12 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:326 +self._dump('Program point:') +self._dump('' + '') Charusso wrote: > I would create a

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added a comment. Sorry for that much rewrite request but in a script language you have to name your stuff properly or you will be completely lost. I have not written a single Python class yet, but trust me. I really like that `DotDumpVisitor` semantic, but it would be a lot better at

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. > I wrote some tests but i'm not really sure they're worth it. Mmm, on second thought, they probably won't work out of the box, because they might require installing python modules in order to work. I'm actually not sure if all machines have python3. I'll try but it'll

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202094. NoQ added a comment. Use `os.path.join` for discovering the utility in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202092. NoQ added a comment. Remove outdated comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot