[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2020-03-23 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. Superseded by D76590 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62688/new/ https://re

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2019-07-31 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. In D62688#1606096 , @baloghadamsoftware wrote: > In D62688#1549574 , @Szelethus wrote: > > > Hmm, an idea just popped into my head. I'm not sure whether we have a > > single checker that

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2019-07-30 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware marked 3 inline comments as done. baloghadamsoftware added a comment. In D62688#1549574 , @Szelethus wrote: > Hmm, an idea just popped into my head. I'm not sure whether we have a single > checker that does so much complicated (and tota

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2019-06-20 Thread Sanaa82016 Najjar via Phabricator via cfe-commits
sanaanajjar231288 added a comment. In D62688#1549574 , @Szelethus wrote: > Hmm, an idea just popped into my head. I'm not sure whether we have a single > checker that does so much complicated (and totally awesome) modeling as > `IteratorChecker`. What d

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2019-06-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1741-1763 +bool isContainer(const CXXRecordDecl *CRD) { + if (!CRD) +return false; + + for (const auto *Decl : CRD->decls()) { +const auto *TD = dyn_cast(Decl); +if (!TD) --

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2019-06-18 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Hmm, an idea just popped into my head. I'm not sure whether we have a single checker that does so much complicated (and totally awesome) modeling as `IteratorChecker`. What do you think about a debug checker similar to `debug.ExprInspection`, like `debug.IteratorInsp

[PATCH] D62688: [Analyzer] Iterator Checkers - Model `empty()` method of containers

2019-05-30 Thread Balogh, Ádám via Phabricator via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Modeling of the `empty()` method