[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc abandoned this revision. mibintc added a comment. I'm abandoning this patch in deference to @kpn 's patch under review D53157 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730 ___

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +FPM_Strict, +FPM_Fast + }; + kpn wrote: > lebedev.ri wrote: > > All this needs comm

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

kpn added inline comments. Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +FPM_Strict, +FPM_Fast + }; + lebedev.ri wrote: > All this needs comments, and possibly better names. > `FPM_Off`,etc is very non-

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

kpn added a comment. Incorporating feedback from D53157 is probably a good idea. Looks like that hasn't been done yet here completely. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730 __

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

lebedev.ri added a comment. New files are missing header blurbs; the **precise** explanation of what is what is missing (should be in `doc/`, not patch description) Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +FPM_Strict

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, kpn. Herald added a subscriber: mgorny. Herald added a project: LLVM. This is part of RFC to support language options -fp-model and -fp-speculation. This makes a small modification to D53157