[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363237: [clangd] Treat lambdas as functions when preparing hover response (authored by kadircet, committed by ). Herald ad

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > i

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 203533. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > kadircet wrote: > > > > ilya-biryukov wrote: > >

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > ilya-biryukov wrote: > > > > Could you add anothe

Re: [PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

AST dump doesn't traverse into typelocs, which is where x is. That said, this particular case is not worth any complexity at all. Even pointer-to-lambda is vanishingly rare. Regarding dropping ref/pointer info: one option here is keeping the old "class (lambda)&", and simply making sure we now po

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:831 + }; return HI; }}, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Could you add another test with even weirder type

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202933. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Please add a check for the type of variable being not null before landing. The other comment is not very important Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:628 +auto QT = VD->getType(); +while (!QT->getPointeeType().isNull()) + QT = QT->getPointeeType(); We need a check for `!QT.isNull` here Comment at

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:819 )cpp", [](HoverInfo &HI) { HI.NamespaceScope = ""; sammccall wrote: > I'm slightly nervous abou

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202888. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/cl

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:657 + auto ToFunctionDecl = [](const Decl *D) -> const FunctionDecl * { +// Extract lambda from variables. can this be a separate function rat

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. In D62814#1528736 , @kadircet wrote: > Nice catch! I think it makes sense to show signature in those cases as well. > Updating according

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202870. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments - Handle pointer/reference types to lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://revi

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet added a comment. Nice catch! I think it makes sense to show signature in those cases as well. Updating according to that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 _

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

ilya-biryukov added a comment. Do we care about pointers or references to lambda types? Comment at: clang-tools-extra/clangd/XRefs.cpp:662 + if (const DecltypeType *DT = + llvm::dyn_cast(VD->getType().getTypePtr())) +if (!DT->getUnderlyingType().isNull

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet updated this revision to Diff 202739. kadircet added a comment. - Get rid of wrong check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62814/new/ https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-ex

[PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D62814 Files: clang-tools-extra/clangd/XRefs.cpp