thakis added inline comments.
Herald added a subscriber: usaxena95.
Comment at: clang-tools-extra/trunk/clangd/test/code-action-request.test:54
+---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365792: [clangd] Implementation of auto type expansion.
(authored by sammccall, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
kuhnel updated this revision to Diff 209234.
kuhnel marked 3 inline comments as done.
kuhnel added a comment.
pair programming with Sam, fixed final issues
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62855/new/
https://reviews.llvm.org/D62855
kuhnel updated this revision to Diff 208923.
kuhnel marked 13 inline comments as done.
kuhnel added a comment.
fixed parts of the 3rd round of review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62855/new/
https://reviews.llvm.org/D62855
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Great, let's land this!
We can enhance further later, but this covers the most common cases.
(I think the remaining comments are trivial - then I/you can land without
further review)
kuhnel updated this revision to Diff 208706.
kuhnel added a comment.
fixed typo on "Deducted"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62855/new/
https://reviews.llvm.org/D62855
Files:
clang-tools-extra/clangd/AST.cpp
kuhnel added inline comments.
Comment at: clang-tools-extra/clangd/AST.cpp:172
+namespace {
+/// Computes the deduced type at a given location by visiting the relevant
sammccall wrote:
> It looks like this has been moved from somewhere (at least code looks
>
kuhnel updated this revision to Diff 208705.
kuhnel marked 22 inline comments as done.
kuhnel added a comment.
Allrighty then, next update:
- moved 2 helper funtions to `AST.cpp`
- added `ASTTests.cpp`
- added more tests
- removed a lot of redundant code
- implemented corner case for not
sammccall added a comment.
Let's chat offline about how to land this.
Main points are:
- we may just be able to use the AutoTypeLoc instead of the separate
RecursiveASTVisitor. (If so, we can do more checks in prepare())
- I have lots of questions about where to draw the line on
lebedev.ri added a comment.
The patch is completely missing description.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62855/new/
https://reviews.llvm.org/D62855
___
cfe-commits mailing list
10 matches
Mail list logo
