[PATCH] D62914: [Sema] Fix diagnostic for addr spaces in reference binding

2019-06-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364023: [Sema] Improved diagnostic for qualifiers in reference binding (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62914: [Sema] Fix diagnostic for addr spaces in reference binding

2019-06-13 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I like this wording of the diagnostic better in general. Could you make the diagnostic change in a separate patch and then fix the address-space problem? Both patches are approved. CHA

[PATCH] D62914: [Sema] Fix diagnostic for addr spaces in reference binding

2019-06-05 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: ebevhan, javed.absar. Extend reference binding behavior to account for address spaces. This change also fixes the diagnostic wording (for qualifier mismatch in reference binding) and simplifies it by