[PATCH] D62962: Clang implementation of sizeless types

2020-11-27 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Was superceded by later revisions, but I forgot to close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962

[PATCH] D62962: Clang implementation of sizeless types

2020-03-03 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Okay, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62962: Clang implementation of sizeless types

2020-03-03 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. In D62962#1887242 , @efriedma wrote: > Can you make a list of the complete stack of patches here? Sorry for the slow reply, I was out last week. I've updated the stack for this revision: the only parent patch is D62961

[PATCH] D62962: Clang implementation of sizeless types

2020-02-21 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Can you make a list of the complete stack of patches here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___ cfe-commits mailing

[PATCH] D62962: Clang implementation of sizeless types

2019-06-28 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Since this is an extension, it wouldb be great to have a (on-by-default? at > least in -Wall) diagnostic for every instance of usage of this extension. We generally only add warnings for extensions which are not allowed by the standard. It's impossible to define a

[PATCH] D62962: Clang implementation of sizeless types

2019-06-28 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Since this is an extension, it wouldb be great to have a (on-by-default? at least in `-Wall`) diagnostic for every instance of usage of this extension. (I guess this is actually true for clang vector extension, too..) Repository: rC Clang CHANGES SINCE LAST

[PATCH] D62962: Clang implementation of sizeless types

2019-06-10 Thread JF Bastien via Phabricator via cfe-commits
jfb added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, _int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2, _int8) == __atomic_always_lock_free(2, incomplete_ptr),

[PATCH] D62962: Clang implementation of sizeless types

2019-06-10 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm marked 2 inline comments as done. rsandifo-arm added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, _int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2,

[PATCH] D62962: Clang implementation of sizeless types

2019-06-10 Thread JF Bastien via Phabricator via cfe-commits
jfb added inline comments. Comment at: test/Sema/sizeless-1.c:66 + _Static_assert(__atomic_always_lock_free(1, _int8) == __atomic_always_lock_free(1, incomplete_ptr), ""); + _Static_assert(__atomic_always_lock_free(2, _int8) == __atomic_always_lock_free(2, incomplete_ptr),

[PATCH] D62962: Clang implementation of sizeless types

2019-06-10 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm marked 4 inline comments as done. rsandifo-arm added a comment. Thanks for the review. In D62962#1534528 , @jfb wrote: > How do these types mangle? At the moment, the mangling is only defined for the Itanium ABI, which uses

[PATCH] D62962: Clang implementation of sizeless types

2019-06-07 Thread JF Bastien via Phabricator via cfe-commits
jfb added a comment. How do these types mangle? Comment at: test/Sema/sizeless-1.c:60 + (void)__atomic_is_lock_free(1, _int8); + (void)__atomic_always_lock_free(1, _int8); + What do you expect these to return? Repository: rC Clang CHANGES SINCE LAST

[PATCH] D62962: Clang implementation of sizeless types

2019-06-07 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm updated this revision to Diff 203546. rsandifo-arm added a comment. Add tests for ext_vector_type Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 Files: docs/SizelessTypes.rst include/clang/AST/Expr.h

[PATCH] D62962: Clang implementation of sizeless types

2019-06-07 Thread JinGu Kang via Phabricator via cfe-commits
jaykang10 added inline comments. Comment at: test/Sema/sizeless-1.c:29 + +typedef svint8_t vec_int8 __attribute__((vector_size(64))); // expected-error {{invalid vector element type}} + Please check "__attribute__((ext_vector_type()))". I guess it is also

[PATCH] D62962: Clang implementation of sizeless types

2019-06-06 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm created this revision. Herald added subscribers: cfe-commits, jfb, kristof.beyls, javed.absar. Herald added a reviewer: rengolin. Herald added a project: clang. This patch adds the concept of "sizeless" types to C and C++. The documentation part of the patch describes the extension