[PATCH] D62970: [clang-doc] De-duplicate comments and locations

This revision was automatically updated to reflect the committed changes. Closed by commit rL364670: [clang-doc] De-duplicate comments and locations (authored by juliehockett, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran updated this revision to Diff 206570. DiegoAstiazaran added a comment. Add comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62970/new/ https://reviews.llvm.org/D62970 Files: clang-tools-extra/clang-doc/Representation.cpp clang-tools-extra/clang-doc/Representa

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

jakehehrlich added a comment. LGTM Comment at: clang-tools-extra/clang-doc/Representation.h:66 + + bool operator<(const CommentInfo &Other) const { +auto FirstCI = std::tie(Kind, Text, Name, Direction, ParamName, CloseName, We should be explicit about what

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124 + for (auto &Comment : Other.Description) { +bool IsCommentUnique = std::find(Description.begin(), Description.end(), +

[PATCH] D62970: [clang-doc] De-duplicate comments and locations

DiegoAstiazaran updated this revision to Diff 204146. DiegoAstiazaran retitled this revision from "[clang-doc] De-duplicate comments" to "[clang-doc] De-duplicate comments and locations". DiegoAstiazaran edited the summary of this revision. DiegoAstiazaran added a comment. Herald added a subscribe

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. In D62970#1533229 , @jakehehrlich wrote: > Actually if we can make Description a hash set that would be best. I think > using std::set would require an awkward < operator to be defined. There > should be standard ways of ge

[PATCH] D62970: [clang-doc] De-duplicate comments

jakehehrlich added a comment. Actually if we can make Description a hash set that would be best. I think using std::set would require an awkward < operator to be defined. There should be standard ways of getting hashes out of all the string and vector types and you can use hash_combine to combi

[PATCH] D62970: [clang-doc] De-duplicate comments

jakehehrlich added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124 + for (auto &Comment : Other.Description) { +bool IsCommentUnique = std::find(Description.begin(), Description.end(), + Comment) == Descript

[PATCH] D62970: [clang-doc] De-duplicate comments

juliehockett added a comment. Please add a test case to `unittests/clang-doc/MergeTest.cpp`. Comment at: clang-tools-extra/clang-doc/Representation.cpp:124-127 +bool IsCommentUnique = std::find(Description.begin(), Description.end(), + Co

[PATCH] D62970: [clang-doc] De-duplicate comments

lebedev.ri added a comment. Test? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62970/new/ https://reviews.llvm.org/D62970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62970: [clang-doc] De-duplicate comments

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. De-duplicate comments in reduce function. When two files include the same header file, this file's content is mapped twice and commen