This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a220de9e9ca: [HIP] Fix visibility for 'extern'
device variables. (authored by hliao).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63020/new/
https://revi
yaxunl accepted this revision.
yaxunl added a subscriber: scchan.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks! @scchan This may fix the undefined symbol in work item struct
issue at -O0
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hliao added a comment.
Sam, could you review this? Even though it has no functionality issue so far,
from the code sequence, once there's an `addrspacecast` is inserted, we lose
the chance to set target specific attributes if any.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
hliao created this revision.
hliao added a reviewer: yaxunl.
Herald added subscribers: cfe-commits, nhaehnle, jvesely.
Herald added a project: clang.
- Fix a bug which misses the change for a variable to be set with
target-specific attributes.
Repository:
rG LLVM Github Monorepo
https://revi
