[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

Trass3r added a comment. That's the general approach for clang-tidy use too, rely on clang-format for formatting the fixes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63085/new/ https://reviews.llvm.org/D63085 ___

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

aaron.ballman added a comment. In D63085#3384302 , @iamsergio wrote: > I don't think we need to worry about formatting, that's the IDE's job (and > whatever formatter it uses). > In general, the code that knows how to warn should also be the one that

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

iamsergio added a comment. Herald added a subscriber: usaxena95. Herald added a project: All. I don't think we need to worry about formatting, that's the IDE's job (and whatever formatter it uses). In general, the code that knows how to warn should also be the one that knows how to fix it, this

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

ilya-biryukov added a comment. One major drawback that I see is the lack of indentation (and other format options) in the added code. Should we have this fix at a higher level that can have formatting (either now or in the future)? E.g. in `clangd` directly? Comment at:

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

sammccall added a comment. Ping... it'd be nice to have for clangd-9, though it's getting late. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63085/new/ https://reviews.llvm.org/D63085 ___ cfe-commits mailing list

[PATCH] D63085: Provide a fix-it hint for -Wswitch, which adds missing cases. If there are >3 cases, the inserted text will contain newlines so it will not be shown in console output (but will be appl

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Lifted the helper for spelling one scope from another from SemaCodeComplete -> AST, to reuse it. It should be